Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code clean-up #6

Open
ghuotvez opened this issue Aug 31, 2023 · 0 comments
Open

Code clean-up #6

ghuotvez opened this issue Aug 31, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@ghuotvez
Copy link
Member

Clean the code

  • Make sure to get the current element object only at one place instead of getting it in every regions for each element types.
  • Get rid of useless comments
  • Get rid of hardcoded values if there is still some, some other should end-up in a third json files I guess, like height constants.
@ghuotvez ghuotvez added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant