Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DView 5-minute lifetime outputs last day is not Dec 31 #289

Closed
cpaulgilman opened this issue Apr 27, 2020 · 2 comments · Fixed by NREL/wex#179
Closed

DView 5-minute lifetime outputs last day is not Dec 31 #289

cpaulgilman opened this issue Apr 27, 2020 · 2 comments · Fixed by NREL/wex#179
Assignees
Labels

Comments

@cpaulgilman
Copy link
Collaborator

For Generic-Battery case with 5-minute liftime simulation, last day is Dec 27:

image

For PV case with 5-minute lifetime simulation, last day is Dec 25:

image

5-min-lifetime-simulations.zip

@cpaulgilman
Copy link
Collaborator Author

See #1616

@cpaulgilman cpaulgilman added this to the SAM Fall 2024 Release milestone Dec 13, 2023
@janinefreeman janinefreeman self-assigned this Oct 2, 2024
@mjprilliman
Copy link
Collaborator

Dview is throwing in Feb 29 once every 4 years in the lifetime outputs. The graphs are taking from the default hourly PV case, which also does not end Dec 31st in the time series graph. The weather file has no leap day in the data.

Year 1 (no leap year):

image

Year 2 (leap year):

image

Year 3-5 (no leap year)

Year 6:

image

25 year analysis period = leap days in years 2,6,10,14,18,22 = 6 days

Last day of lifetime array = Dec 25; 31 - 25 = 6 days missing.

image

Now to figure out how to fix that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants