This repository has been archived by the owner on Apr 16, 2024. It is now read-only.
[WIP] Fixed LSP servers not installing with +lsp in doomrc #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTBBloodbath
approved these changes
Oct 1, 2021
There was a problem hiding this comment.
Hi, thank you so much per doing this. Everything looks good to me, awesome work mate!
There's still some bugs that I need to iron out before this is production ready.
Are those bugs still here? Being honest I can't find any bug right now. Let me know if they're already squashed so we can merge this awesome fix :)
p.s.: you can ignore the linter CI failing, it's complaining about a trailing whitespace in a comment and our formatter should get rid of it after merging this.
NTBBloodbath
added
branch: main
|
Hmmm Yeah you're right, I was getting an indexing error but I think that was due to some other changes that packer was caching or something. Sweet, happy to help :) |
This was referenced Oct 2, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the issue is due to a race condition from the part of the code that installs the LSPs running before Packer is done lazy loading nvim-lspinstall and nvim-lspconfig. I mirrored the way nvim-treesitter works by moving the installation into the config file of
nvim-lspinstall. There's still some bugs that I need to iron out before this is production ready.This is still a work in progress, open to feedback :)
Start of discussion in #87