Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] #295

Closed
OlenaBugaiova opened this issue Oct 19, 2021 · 2 comments
Closed

[DOC] #295

OlenaBugaiova opened this issue Oct 19, 2021 · 2 comments

Comments

@OlenaBugaiova
Copy link

Report incorrect documentation

Location of incorrect documentation

https://github.com/NVIDIA-Merlin/Transformers4Rec/blob/main/examples/README.md?plain=1
Line number 26 and 35

Describe the problems or issues found in the documentation

Links for "Tutorial - End-to-End Session-Based Recommendation on GPU" and "Transformers4Rec paper experiments reproducibility" are missing "examples/" in the path.

Steps taken to verify documentation is incorrect

To click on the links:
Tutorial - End-to-End Session-Based Recommendation on GPU
Transformers4Rec paper experiments reproducibility
Expected: to follow the link
Actual: 404 error

Suggested fix for documentation

To update:
https://github.com/NVIDIA-Merlin/Transformers4Rec/tree/main/tutorial/ to https://github.com/NVIDIA-Merlin/Transformers4Rec/tree/main/examples/tutorial/
and
https://github.com/NVIDIA-Merlin/Transformers4Rec/tree/main/t4rec_paper_experiments/ to https://github.com/NVIDIA-Merlin/Transformers4Rec/tree/main/examples/t4rec_paper_experiments/


Report needed documentation

Report needed documentation

Describe the documentation you'd like

Steps taken to search for needed documentation**

@rnyak
Copy link
Contributor

rnyak commented Oct 19, 2021

@OlenaBugaiova thanks for reporting this. #296 addresses this issue.

@OlenaBugaiova
Copy link
Author

@rnyak great, I'm closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants