Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable perf tests to work for forks #331

Closed
pranavm-nvidia opened this issue Nov 1, 2024 · 1 comment
Closed

Enable perf tests to work for forks #331

pranavm-nvidia opened this issue Nov 1, 2024 · 1 comment

Comments

@pranavm-nvidia
Copy link
Collaborator

Our performance tests don't currently work for PRs from forks because they depend on pushing benchmark data to a branch on the main repo, for which forks do not have permission. We should instead make this push happen during the post-merge pipeline. We will need to figure out how to communicate artifacts generated from testing to the post-merge stage. Otherwise, we would have to run perf tests twice.
@pranavm-nvidia
Copy link
Collaborator Author

pranavm-nvidia commented Dec 18, 2024 •
edited
Loading

Should be addressed by #456 and #458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pranavm-nvidia