Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return_log_probs slow down generation #2367

Open
4 tasks
Desmond819 opened this issue Oct 24, 2024 · 2 comments
Open
4 tasks

return_log_probs slow down generation #2367

Desmond819 opened this issue Oct 24, 2024 · 2 comments
Labels
bug Something isn't working Investigating performance issue Issue about performance number

Comments

@Desmond819
Copy link

Desmond819 commented Oct 24, 2024

System Info

Hi team,

when I try to add return_log_probs true and output_log_probs = true to return logprob, the generation speed degraded significantly. Below is my testing.

time curl -X POST localhost:8080/v2/models/ensemble/generate_stream -d '{"text_input": "Explain in detail 5 important events of WW2.", "parameters": {"max_tokens": 2000,"bad_words":[""],"stop_words":[""],"stream": true,"temperature": 0.0}}' | grep 'data: ' | wc -l

Result: 0m6.186s

time curl -X POST localhost:8080/v2/models/ensemble/generate_stream -d '{"text_input": "Explain in detail 5 important events of WW2.", "parameters": {"max_tokens": 2000,"bad_words":[""],"stop_words":[""],"stream": true,"temperature": 0.0, "return_log_probs": true}}' | grep 'data: ' | wc -l

Result: 1m9.191s

I am running Meta-Llama-3.1-8B-Instruct on a 8xH100 with TP8.

Who can help?

No response

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction

See above

Expected behavior

NA

actual behavior

NA

additional notes

NA

@Desmond819 Desmond819 added the bug Something isn't working label Oct 24, 2024
@Superjomn
Copy link
Collaborator

Thanks for sharing the issue.
I wonder what API you are using. The triton-backend, the openai_server.py or anything else? @Desmond819

@Superjomn Superjomn added performance issue Issue about performance number Investigating labels Oct 24, 2024
@Desmond819
Copy link
Author

I am using triton-backend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Investigating performance issue Issue about performance number
Projects
None yet
Development

No branches or pull requests

2 participants