From bce3c2a8dac113cc8acbe13f0c123d730bc00af1 Mon Sep 17 00:00:00 2001 From: Taekyung Heo <7621438+TaekyungHeo@users.noreply.github.com> Date: Tue, 4 Jun 2024 14:40:52 -0400 Subject: [PATCH] Ensure proper conversion of 'cache_docker_images_locally' to boolean --- src/cloudai/parser/system_parser/slurm_system_parser.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/cloudai/parser/system_parser/slurm_system_parser.py b/src/cloudai/parser/system_parser/slurm_system_parser.py index acf9c539..158e2cb6 100644 --- a/src/cloudai/parser/system_parser/slurm_system_parser.py +++ b/src/cloudai/parser/system_parser/slurm_system_parser.py @@ -43,6 +43,9 @@ def safe_int(value): except ValueError: return None + def str_to_bool(value: str) -> bool: + return value.lower() in ("true", "1", "yes") + name = data.get("name") if not name: raise ValueError("Missing mandatory field: 'name'") @@ -78,7 +81,7 @@ def safe_int(value): gpus_per_node = safe_int(data.get("gpus_per_node")) ntasks_per_node = safe_int(data.get("ntasks_per_node")) - cache_docker_images_locally = data.get("cache_docker_images_locally", False) + cache_docker_images_locally = str_to_bool(data.get("cache_docker_images_locally", "False")) nodes_dict: Dict[str, SlurmNode] = {} updated_partitions: Dict[str, List[SlurmNode]] = {}