Hierarchical Test template for support Grok/GPT via PAXML #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srivatsankrishnan
changed the title
TaekyungHeo
previously approved these changes
Jul 24, 2024
|
Approved. Let's see if @amaslenn has any comments and wait for @srinivas212 to merge this. @amaslenn, this PR supports two different subtests in the JAX Toolbox test templates. This allows us to support Grok and GPT simultaneously in a hierarchical manner. The related PR is https://github.com/Mellanox/cloudaix/pull/2. |
amaslenn
requested changes
Jul 24, 2024
src/cloudai/schema/test_template/jax_toolbox/slurm_command_gen_strategy.py
Outdated
Show resolved
Hide resolved
amaslenn
previously approved these changes
Jul 25, 2024
TaekyungHeo
previously approved these changes
Jul 30, 2024
TaekyungHeo
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modification to Jaxtoolbox to support hierarchical test template to support both GPT and Grok models via PAXML.
Test Plan
Internal testing and pytests
Additional Notes
Needs additional testing on same container. XLA Flags seems to have changed. It requires debugging to make Grok working on the same container.