Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logging.config and do not pass CLI args as a parameter #73

Merged
merged 7 commits into from
Jun 6, 2024

Conversation

amaslenn
Copy link
Contributor

@amaslenn amaslenn commented Jun 5, 2024

Summary

  1. Use logging.config, always write DEBUG logs into debug file.
  2. Use module-level logger object for better configurability on user end.
  3. Use explicit arguments instead of argparse's args for high level function. It will simplify code re-use for users.

Test Plan

CI

Additional Notes

@TaekyungHeo TaekyungHeo added the enhancement New feature or request label Jun 5, 2024
@TaekyungHeo
Copy link
Member

TaekyungHeo commented Jun 5, 2024

I can merge when you rebase. @srinivas212 confirmed.

@TaekyungHeo TaekyungHeo merged commit deb9c9d into main Jun 6, 2024
2 checks passed
@amaslenn amaslenn deleted the no-args-logging branch June 6, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants