Add credentials for NGC to README #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lappazos
force-pushed
the
add_credentials_readme
branch
2 times, most recently
from
96ecbbc
to
3119027
Compare
|
Should this go under https://github.com/NVIDIA/cloudai/blob/main/USER_GUIDE.md instead? |
lappazos
force-pushed
the
add_credentials_readme
branch
from
3119027
to
0c12fc8
Compare
I believe it belongs to README, as it is a required part of the needed step for installation. Also, README is the first document you encounter when opening the repo. Some users asked me how to do that. But also USER_GUIDE can fit, so whatever you decide. which one should it be? |
|
@TaekyungHeo please review as well |
TaekyungHeo
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add additional information to user on needed step to add required credentials to NGC containers.
Additional Notes
Following #21