Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unit test for checking the copyright headers and removing the check_copyright_headers in ci_tools #87

Merged
merged 8 commits into from
Jun 7, 2024

Conversation

srivatsankrishnan
Copy link
Collaborator

Summary

Added pytest for checking copyright headers and removed the ci_tools\check_copyright_headers.py as suggested by @TaekyungHeo.

Test Plan

Run the pytest

$ pytest --vv --cov

@srivatsankrishnan srivatsankrishnan changed the title Adding unit test for checking the copyright headers and removing the ci_tools Adding unit test for checking the copyright headers and removing the check_copyright_headers in ci_tools Jun 6, 2024
@srivatsankrishnan srivatsankrishnan marked this pull request as ready for review June 6, 2024 21:22
Copy link
Member

@TaekyungHeo TaekyungHeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's validate full copyright notice. Reason - In CloudAIX, we have a single-line notice.

# Copyright (c) 2024, NVIDIA CORPORATION.  All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

@srivatsankrishnan
Copy link
Collaborator Author

Looks like the vulture relies on ci_tools? @TaekyungHeo

Copy link
Member

@TaekyungHeo TaekyungHeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for @amaslenn and @srinivas212.

@TaekyungHeo TaekyungHeo merged commit 2795e98 into NVIDIA:main Jun 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants