Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Semantic versioning #190

Open
sleeepyjack opened this issue Jul 20, 2022 · 4 comments
Open

[FEA] Semantic versioning #190

sleeepyjack opened this issue Jul 20, 2022 · 4 comments
Labels
P3: Backlog Unprioritized type: feature request New feature request

Comments

@sleeepyjack
Copy link
Collaborator

How do we want to employ semantic versioning for this library?

Thrust for instance updates the release version by hand by setting new values in thrust/version.h.

This is required if we opt for versioned inline namespaces to solve #189.

@PointKernel
Copy link
Member

cuCo doesn't have a release yet thus I'm not sure how to incorporate the versioned inline namespace in our case. e.g. how to name the version.

@sleeepyjack
Copy link
Collaborator Author

Yeah, that's true. Maybe we could push a development tag 0.1.0 to dev and use that as an intermediate?

@jrhemstad
Copy link
Collaborator

Inline namespaces won't solve #189 in the short term because we aren't going to bump the version with every PR.

The best short term solution for #189 is the custom namespace prefix.

@sleeepyjack
Copy link
Collaborator Author

Ok, then we can put this issue in the backlog for now.

@PointKernel PointKernel added the P3: Backlog Unprioritized label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3: Backlog Unprioritized type: feature request New feature request
Projects
None yet
Development

No branches or pull requests

3 participants