Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛[BUG]: License header checks output folders #52

Closed
NickGeneva opened this issue Jul 25, 2023 · 2 comments · Fixed by #61
Closed

🐛[BUG]: License header checks output folders #52

NickGeneva opened this issue Jul 25, 2023 · 2 comments · Fixed by #61
Assignees
@mnabian
Labels
2 - In Progress Currently a work in progress bug Something isn't working

Comments

@NickGeneva
Copy link
Collaborator

Version

0.1.0

On which installation method(s) does this occur?

No response

Describe the issue

License header check also looks at output / mlrun folders in the examples. There needs to be an added option for excluding folders with a given pattern.

Minimum reproducible example

No response

Relevant log output

No response

Environment details

No response

Other/Misc.

No response
@NickGeneva NickGeneva added the bug Something isn't working label Jul 25, 2023
@NickGeneva NickGeneva changed the title 🐛[BUG]: 🐛[BUG]: License header checks output folders Jul 25, 2023
@mnabian mnabian self-assigned this Jul 26, 2023
@mnabian
Copy link
Collaborator

mnabian commented Jul 26, 2023

@NickGeneva I think there is already an option for excluding specific directories form the header test: https://github.com/NVIDIA/modulus-launch/blob/main/test/ci_tests/config.json#L5. Would this work?

@mnabian mnabian mentioned this issue Jul 27, 2023
Merged
4 tasks
@NickGeneva NickGeneva added the 2 - In Progress Currently a work in progress label Jul 27, 2023
@NickGeneva
Copy link
Collaborator Author

Fixed in: #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnabian mnabian

Labels
2 - In Progress Currently a work in progress bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fea-ext-ignore_.gitignore_paths_in_header_test mnabian/modulus-launch
3 participants
@loliverhennigh @NickGeneva @mnabian