Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update default configs #67

Merged
merged 2 commits into from
Jul 28, 2023
Merged

update default configs #67

merged 2 commits into from
Jul 28, 2023

Conversation

mnabian
Copy link
Collaborator

@mnabian mnabian commented Jul 28, 2023 •
edited by NickGeneva
Loading

Modulus Pull Request

Description

Fixes: #65

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is
    up to date with these changes.

Dependencies

@mnabian mnabian requested a review from NickGeneva July 28, 2023 00:57
@mnabian mnabian self-assigned this Jul 28, 2023
@mnabian mnabian added the bug Something isn't working label Jul 28, 2023
@mnabian
Copy link
Collaborator Author

mnabian commented Jul 28, 2023

/blossom-ci

NickGeneva
NickGeneva approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@NickGeneva NickGeneva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick fix!

@NickGeneva NickGeneva added the 2 - In Progress Currently a work in progress label Jul 28, 2023
@mnabian mnabian removed the 2 - In Progress Currently a work in progress label Jul 28, 2023
@mnabian mnabian merged commit 74c5d82 into NVIDIA:main Jul 28, 2023
@mnabian mnabian deleted the bug-ext-sfno_configs branch July 28, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickGeneva NickGeneva NickGeneva approved these changes

Assignees

@mnabian mnabian

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛[BUG]: SFNO default parameter config does not work
2 participants
@mnabian @NickGeneva