Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the missing denormalization of the pressure #87

Merged
merged 2 commits into from
Aug 10, 2023
Merged

add the missing denormalization of the pressure #87

merged 2 commits into from
Aug 10, 2023

Conversation

sifanexisted
Copy link
Contributor

Modulus Pull Request

Description

closes #86

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is
    up to date with these changes.

Dependencies

@mnabian mnabian self-requested a review August 10, 2023 23:25
@mnabian mnabian added the bug Something isn't working label Aug 10, 2023
@mnabian
Copy link
Collaborator

mnabian commented Aug 10, 2023

/blossom-ci

mnabian
mnabian approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@mnabian mnabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktangsali ktangsali merged commit 846be44 into NVIDIA:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnabian mnabian mnabian approved these changes

Assignees

@sifanexisted sifanexisted

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛[BUG]: incorrect pressure inference in vortex_shedding_mgn example
3 participants
@sifanexisted @mnabian @ktangsali