Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split some big files into small ones for better reading #105

Open
GaryShen2008 opened this issue Aug 26, 2022 · 1 comment
Open

Split some big files into small ones for better reading #105

GaryShen2008 opened this issue Aug 26, 2022 · 1 comment

Comments

@GaryShen2008
Copy link
Collaborator

Problem:
Some files like nds_transocde.py, nds_bench.py are too big to read.

Expectation:
We should move out some parts in these big files to new files.
Like get_schemas in nds_transcode.py, we can create a new file to only define schema related, and it's also referred by multiple python scripts.
In nds_bench.py, we can move out the functions which analyze the report file to some utils file, so that only keep the step functions and main process, it should be clear to read.

@GaryShen2008
Copy link
Collaborator Author

It seems not easy to move the code of reading and writing report file to one place.
We can consider it in the future.

@GaryShen2008 GaryShen2008 changed the title Refactor the code to split some big files into small ones for better reading Split some big files into small ones for better reading Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant