Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rapids Shuffle - UcpListener #1590

Closed
abellina opened this issue Jan 26, 2021 · 1 comment · Fixed by #2886
Closed

Rapids Shuffle - UcpListener #1590

abellina opened this issue Jan 26, 2021 · 1 comment · Fixed by #2886
Labels
feature request New feature or request shuffle things that impact the shuffle plugin

Comments

@abellina
Copy link
Collaborator

Use UcpListener to connect to peers instead of our own connection. This will enable us to exchange the socket address to communicate with UCX. UCX keeps the connection alive, which allows it detect peer disconnection, which should help with reliability of the rapids shuffle.

This also removes TCP code that was added to exchange UCX's WorkerAddress, so it should end up cleaning code required for this exchange.

@abellina abellina added feature request New feature or request ? - Needs Triage Need team to review and classify shuffle things that impact the shuffle plugin labels Jan 26, 2021
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jan 26, 2021
@abellina
Copy link
Collaborator Author

@petro-rudenko has a PR for this already, we need to follow up with removal of management port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request shuffle things that impact the shuffle plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants