Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] GPU support for the plan RunningWindowFunctionExec on db #1791

Closed
firestarman opened this issue Feb 23, 2021 · 1 comment · Fixed by #2600
Closed

[FEA] GPU support for the plan RunningWindowFunctionExec on db #1791

firestarman opened this issue Feb 23, 2021 · 1 comment · Fixed by #2600
Assignees
Labels
feature request New feature or request

Comments

@firestarman
Copy link
Collaborator

firestarman commented Feb 23, 2021

Is your feature request related to a problem? Please describe.
On databricks, the plan RunningWindowFunctionExec , which has not been supported by GPU, will be applied instead of the WindowExec when matching some requirements. Then some window related IT tests will fail.
Some related ssues: #1680 #203

Describe the solution you'd like
Replace the plan RunningWindowFunctionExec with a new or existing GPU plan correctly.

Additional context
RunningWindowRunctionExec does not exist outside of Databricks, and will NOT be used when

  • window function is a SizeBasedWindowFunction, or
  • window function is a OffsetWindowFunction, or
  • window function is a PythonUDF, or
  • window frame specification is not SpecifiedWindowFrame(RowFrame, UnboundedPreceding, CurrentRow)

Since databricks is not open source, so it may not be easy to understand what RunningWindowRunctionExec does and how to support it on GPU perfectly.

@firestarman firestarman added feature request New feature or request ? - Needs Triage Need team to review and classify labels Feb 23, 2021
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Feb 23, 2021
@mythrocks mythrocks self-assigned this May 28, 2021
@mythrocks
Copy link
Collaborator

For reference, we need the following window spec to reproduce the problem:

... OVER (PARTITION BY id ORDER BY dt ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW)

Hence, the term RunningWindowFunctionExec. Reversing the boundaries (i.e. CURRENT ROW AND UNBOUNDED FOLLOWING) does not suffice, for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants