Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix more edge cases when parsing dates in legacy timeParserPolicy #2937

Closed
andygrove opened this issue Jul 15, 2021 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@andygrove
Copy link
Contributor

Describe the bug
Through further fuzzing, I found additional edge cases. We should update the ParseDateTimeSuite tests to use the fuzzer as we fix these.

Mismatch between CPU and GPU for the following rows:

[#672] CPU: [2/3/2
6T56,0002-03-02]
[#672] GPU: [2/3/2
6T56,null]

[#3238] CPU: [4/7/6-9/,0004-07-06]
[#3238] GPU: [4/7/6-9/,null]

Steps/Code to reproduce bug
Test with values generated by FuzzerUtils.generateRandomStrings(Some(" \t\r\n0123456789:-/TZ")).

Expected behavior
CPU and GPU should match.

Environment details (please complete the following information)
N/A

Additional context
N/A

@andygrove andygrove added bug Something isn't working ? - Needs Triage Need team to review and classify labels Jul 15, 2021
@andygrove andygrove added this to the July 5 - July 16 milestone Jul 15, 2021
@andygrove andygrove self-assigned this Jul 15, 2021
@andygrove
Copy link
Contributor Author

These values have single-digit year which we already document that we don't support, but we could do additional work to support them.

@andygrove andygrove removed this from the July 5 - July 16 milestone Jul 16, 2021
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants