Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualification & Profiling tool: Add automated tests to run inside CSPs. #2954

Closed
viadea opened this issue Jul 16, 2021 · 8 comments · Fixed by #4217
Closed

Qualification & Profiling tool: Add automated tests to run inside CSPs. #2954

viadea opened this issue Jul 16, 2021 · 8 comments · Fixed by #4217
Assignees
Labels
P0 Must have for release test Only impacts tests tools

Comments

@viadea
Copy link
Collaborator

viadea commented Jul 16, 2021

We need to add automated tests to run Qualification & Profiling tool inside CSPs -- Databricks/EMR/Dataproc, and also CDP at least once per week.
We can rotate the CSPs/CDP envs each time.

The goal is to make sure the tool can be submitted inside those envs using their spark jars.

@viadea viadea added test Only impacts tests P0 Must have for release tools labels Jul 16, 2021
@zhanga5
Copy link
Contributor

zhanga5 commented Aug 10, 2021

as @tgravescs refined both tools won't require using Spark and SQL any more, is this issue still valid?

@tgravescs
Copy link
Collaborator

We still require the Spark jars to be present since we use classes from them so I think this would still be good to do.

@zhanga5
Copy link
Contributor

zhanga5 commented Aug 12, 2021

I see. Any idea about what kind of event logs and where to keep it for these testings?

@tgravescs
Copy link
Collaborator

I think for this if we are running inside the CSP we just run some jobs to generate the logs and then read them there. That way no storing of event logs and we regenerate everytime and make sure CSP didn't change anything in formatting that would break us.

As far as what to run we could either run some of the integration tests and then run on the event logs generated from that, let me look into that a bit more.

@tgravescs
Copy link
Collaborator

cdp part of this split out into #3360

@tgravescs tgravescs changed the title Qualification & Profiling tool: Add automated tests to run inside CSPs and CDP. Qualification & Profiling tool: Add automated tests to run inside CSPs. Sep 1, 2021
@tgravescs
Copy link
Collaborator

We want to run on event logs generated by running jobs on those. One thought is to start out with just running them on the integration test event logs. Then I think we would want to add in a couple of more specific tests, which perhaps we can add into just the tools test suite area.

@zhanga5
Copy link
Contributor

zhanga5 commented Dec 6, 2021

it's completed for Databricks environment while still in progress for Dataproc. It would be completed soon.

@zhanga5
Copy link
Contributor

zhanga5 commented Dec 8, 2021

test from Dataproc environment is completed

@zhanga5 zhanga5 closed this as completed Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Must have for release test Only impacts tests tools
Projects
None yet
5 participants