Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] support nested structs in collect_set #3152

Closed
revans2 opened this issue Aug 5, 2021 · 3 comments · Fixed by #3700
Closed

[FEA] support nested structs in collect_set #3152

revans2 opened this issue Aug 5, 2021 · 3 comments · Fixed by #3700
Assignees
@wbo4958
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request

Comments

@revans2
Copy link
Collaborator

revans2 commented Aug 5, 2021

Is your feature request related to a problem? Please describe.
I filed the cudf issue rapidsai/cudf#8972 to get cudf support for nested structs in collect_set and merge_set. When that is done we need to update the tests and the type checks for collect_set and verify that it works.
@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify cudf_dependency An issue or PR with this label depends on a new feature in cudf labels Aug 5, 2021
@Salonijain27 Salonijain27 removed the ? - Needs Triage Need team to review and classify label Aug 10, 2021
@ttnghia
Copy link
Collaborator

ttnghia commented Sep 21, 2021

I'm not sure if this is duplicate issue: #3514

@ttnghia
Copy link
Collaborator

ttnghia commented Sep 21, 2021

FYI: The cudf issue is addressed. Now we can start plugin work.

@sperlingxx sperlingxx self-assigned this Sep 27, 2021
@wbo4958 wbo4958 mentioned this issue Sep 29, 2021
Merged
@wbo4958 wbo4958 linked a pull request Sep 30, 2021 that will close this issue
CollectSet supports structs #3700
Merged
@wbo4958
Copy link
Collaborator

wbo4958 commented Oct 11, 2021

PR merged. Close this issue.

@wbo4958 wbo4958 closed this as completed Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wbo4958 wbo4958

Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CollectSet supports structs wbo4958/spark-rapids
5 participants
@wbo4958 @revans2 @sperlingxx @ttnghia @Salonijain27