Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove total time metrics from most GPU nodes in the plan #3243

Closed
jlowe opened this issue Aug 17, 2021 · 0 comments
Closed

Remove total time metrics from most GPU nodes in the plan #3243

jlowe opened this issue Aug 17, 2021 · 0 comments
Assignees
Labels
task Work required that improves the product but is not user facing

Comments

@jlowe
Copy link
Member

jlowe commented Aug 17, 2021

Many exec nodes in the plan have a "total time" metric that records the entire time spent in that node, including time spent waiting for the input iterator(s) hasNext and next calls. I'm not sure this is very useful in practice, and many users think this metric represents time spent solely operating on the node, when often it is more measuring the time spent waiting for inputs. Almost all the exec nodes have a separate metric that records the time spent locally operating on the GPU which in practice is much more useful.

Given we've seen cases where too many metrics have been generated while executing the plan, we should consider removing this one across the board, or at least only keeping it for a select few exec nodes where it makes sense.

@jlowe jlowe added ? - Needs Triage Need team to review and classify task Work required that improves the product but is not user facing labels Aug 17, 2021
@Salonijain27 Salonijain27 removed the ? - Needs Triage Need team to review and classify label Aug 24, 2021
@revans2 revans2 self-assigned this Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Work required that improves the product but is not user facing
Projects
None yet
Development

No branches or pull requests

3 participants