Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] pre-merge jenkinsfile compatibility #3247

Closed
pxLi opened this issue Aug 18, 2021 · 0 comments · Fixed by #3312
Closed

[FEA] pre-merge jenkinsfile compatibility #3247

pxLi opened this issue Aug 18, 2021 · 0 comments · Fixed by #3312
Assignees
@zhanga5
Labels
build Related to CI / CD or cleanly building test Only impacts tests

Comments

@pxLi
Copy link
Collaborator

pxLi commented Aug 18, 2021 •
edited
Loading

related to #2731

We currently enable single jenkinsfile for all dev branches, this could introduce compatibility issue like

spark-rapids/jenkins/spark-premerge-build.sh

Line 96 in a014c2c

# TODO: this function should be named as 'integration_test()' but it would break backward compatibility. Need find a way to fix this.

Please help investigate if any good way for these cases.
@pxLi pxLi added test Only impacts tests build Related to CI / CD or cleanly building labels Aug 18, 2021
@pxLi pxLi mentioned this issue Aug 19, 2021
Closed
@zhanga5 zhanga5 linked a pull request Aug 26, 2021 that will close this issue
Fix inconsistent function name and add backward compatibility support for premerge job [skip ci] #3312
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhanga5 zhanga5

Labels
build Related to CI / CD or cleanly building test Only impacts tests
Projects
None yet
Milestone
No milestone
2 participants
@pxLi @zhanga5