Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kryo integration tests #3490

Closed
tgravescs opened this issue Sep 15, 2021 · 3 comments · Fixed by #3860
Closed

Add Kryo integration tests #3490

tgravescs opened this issue Sep 15, 2021 · 3 comments · Fixed by #3860
Assignees
Labels
task Work required that improves the product but is not user facing test Only impacts tests

Comments

@tgravescs
Copy link
Collaborator

Describe the bug
We have had issues with kryo not being updated or failing. CDH runs with Kryo on all the time, we need to get some integration tests that run with kryo on.

@tgravescs tgravescs added ? - Needs Triage Need team to review and classify task Work required that improves the product but is not user facing labels Sep 15, 2021
@tgravescs
Copy link
Collaborator Author

reference #3468

@sameerz sameerz added test Only impacts tests and removed ? - Needs Triage Need team to review and classify labels Oct 5, 2021
@wbo4958 wbo4958 self-assigned this Oct 14, 2021
@wbo4958
Copy link
Collaborator

wbo4958 commented Oct 19, 2021

Hi Tom, It's hard to add integration test for GpuKryoRegistrator since we can't modify the "spark.serializer" conf during runtime.

I just added a unit test for it. Could you help to give some comments on it?

@tgravescs
Copy link
Collaborator Author

I think a unit test here is fine, we could also potentially run it in the nightly as a separate command but that would likely take longer. I'll take a look at pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Work required that improves the product but is not user facing test Only impacts tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants