Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support approx_percentile on GPU with decimal type #3606

Closed
andygrove opened this issue Sep 22, 2021 · 1 comment
Closed

[FEA] Support approx_percentile on GPU with decimal type #3606

andygrove opened this issue Sep 22, 2021 · 1 comment
Assignees
Labels
feature request New feature or request

Comments

@andygrove
Copy link
Contributor

andygrove commented Sep 22, 2021

Is your feature request related to a problem? Please describe.
I ran into an issue with approx_percentile and decimal types so I am planning on having these fall back to CPU in #3301 unless I can resolve the issue quickly and then address this in a follow-on PR.

E                   Caused by: java.lang.AssertionError:  value at 0 is null
E                   	at ai.rapids.cudf.HostColumnVectorCore.assertsForGet(HostColumnVectorCore.java:228)
E                   	at ai.rapids.cudf.HostColumnVectorCore.getLong(HostColumnVectorCore.java:301)
E                   	at com.nvidia.spark.rapids.RapidsHostColumnVectorCore.getDecimal(RapidsHostColumnVectorCore.java:171)
E                   	at org.apache.spark.sql.vectorized.ColumnarArray.getDecimal(ColumnarArray.java:143)
E                   	at org.apache.spark.sql.catalyst.expressions.GeneratedClass$SpecificUnsafeProjection.apply(Unknown Source)
E                   	at org.apache.spark.sql.catalyst.expressions.GeneratedClass$SpecificUnsafeProjection.apply(Unknown Source)
E                   	at scala.collection.Iterator$$anon$10.next(Iterator.scala:459)
E                   	at org.apache.spark.sql.execution.SparkPlan.$anonfun$getByteArrayRdd$1(SparkPlan.scala:346)
E                   	at org.apache.spark.rdd.RDD.$anonfun$mapPartitionsInternal$2(RDD.scala:898)

Describe the solution you'd like
Enable the commented out tests in hash_aggregate_test,py

Describe alternatives you've considered
None

Additional context
None

@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels Sep 22, 2021
@andygrove andygrove added this to the Sep 13 - Sep 24 milestone Sep 22, 2021
@andygrove andygrove self-assigned this Sep 22, 2021
@andygrove andygrove mentioned this issue Sep 22, 2021
8 tasks
@andygrove
Copy link
Contributor Author

This was a red herring - the issue went away after upmerging cuDF

@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants