Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] release312db profile pulls in 311until320-apache #3613

Closed
tgravescs opened this issue Sep 22, 2021 · 1 comment · Fixed by #4193
Closed

[BUG] release312db profile pulls in 311until320-apache #3613

tgravescs opened this issue Sep 22, 2021 · 1 comment · Fixed by #4193
Assignees
@res-life
Labels
bug Something isn't working P1 Nice to have for release

Comments

@tgravescs
Copy link
Collaborator

tgravescs commented Sep 22, 2021 •
edited
Loading

Describe the bug
somehow 311until320-apache got added into the release312db profile for databricks. I take apache as meaning all Apache release which wouldn't include databricks, cdh, or other vendor specific implementation, we should remove that and move files as needed.
@tgravescs tgravescs added bug Something isn't working ? - Needs Triage Need team to review and classify labels Sep 22, 2021
@Salonijain27 Salonijain27 removed the ? - Needs Triage Need team to review and classify label Sep 28, 2021
@Salonijain27 Salonijain27 added the P1 Nice to have for release label Sep 28, 2021
@tgravescs tgravescs changed the title [BUG] release311db profile pulls in 311until320-apache [BUG] release312db profile pulls in 311until320-apache Nov 12, 2021
@res-life res-life self-assigned this Nov 19, 2021
@gerashegalov
Copy link
Collaborator

gerashegalov commented Nov 23, 2021 •
edited
Loading

Looking at the content, the directory has a single file ShimVectorizedColumnReader.scala that looks different only for CDH in the profiles covering [311; 320) version range profiles. So I think the right solution is to rename the dir and its references to 311until320-noncdh or something like that.

@res-life res-life mentioned this issue Nov 23, 2021
Merged
@res-life res-life linked a pull request Nov 24, 2021 that will close this issue
Rename 311until320-apache to 311until320-noncdh #4193
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@res-life res-life

Labels
bug Something isn't working P1 Nice to have for release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename 311until320-apache to 311until320-noncdh res-life/spark-rapids
4 participants
@gerashegalov @tgravescs @res-life @Salonijain27