Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] ParquetMaterializer.scala appears in both v1 and v2 shims #3614

Closed
jlowe opened this issue Sep 22, 2021 · 0 comments · Fixed by #3778
Closed

[BUG] ParquetMaterializer.scala appears in both v1 and v2 shims #3614

jlowe opened this issue Sep 22, 2021 · 0 comments · Fixed by #3778
Assignees
@tgravescs
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jlowe
Copy link
Member

jlowe commented Sep 22, 2021

ParquetMaterializer.scala appears in the spark311db shim as well as the v2 shim in sql-plugin:

$ find . | grep ParquetMaterializer.scala
./shims/spark311db/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/rapids/shims/spark311db/ParquetMaterializer.scala
./sql-plugin/src/main/311+-all/scala/org/apache/spark/sql/execution/datasources/parquet/rapids/ParquetMaterializer.scala

The spark311db version should be removed.
@jlowe jlowe added bug Something isn't working good first issue Good for newcomers ? - Needs Triage Need team to review and classify labels Sep 22, 2021
@Salonijain27 Salonijain27 removed the ? - Needs Triage Need team to review and classify label Sep 28, 2021
@tgravescs tgravescs mentioned this issue Oct 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgravescs tgravescs

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove extra ParquetMaterializer.scala file tgravescs/spark-rapids
3 participants
@jlowe @tgravescs @Salonijain27