Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premerge test with combined jar #3654

Closed
tgravescs opened this issue Sep 24, 2021 · 2 comments · Fixed by #3801
Closed

Premerge test with combined jar #3654

tgravescs opened this issue Sep 24, 2021 · 2 comments · Fixed by #3801
Assignees
Labels
build Related to CI / CD or cleanly building

Comments

@tgravescs
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently the premerge just uses the individual profile to run the tests, it would be nice to use the combined jar -Psnapshots to make sure no issues with multiple jars combined. The problem is we run jacoco and it doesn't seem to like the combined jar.

10:12:54  java.lang.IllegalStateException: Can't add different class with same name: com/nvidia/spark/rapids/AvoidAdaptiveTransitionToRow
10:12:54  	at org.jacoco.core.analysis.CoverageBuilder.visitCoverage(CoverageBuilder.java:106)
10:12:54  	at org.jacoco.core.analysis.Analyzer$1.visitEnd(Analyzer.java:99)
10:12:54  	at org.objectweb.asm.ClassVisitor.visitEnd(ClassVisitor.java:377)
10:12:54  	at org.jacoco.core.internal.flow.ClassProbesAdapter.visitEnd(ClassProbesAdapter.java:100)
10:12:54  	at org.objectweb.asm.ClassReader.accept(ClassReader.java:725)
10:12:54  	at org.objectweb.asm.ClassReader.accept(ClassReader.java:401)
10:12:54  	at org.jacoco.core.analysis.Analyzer.analyzeClass(Analyzer.java:116)
10:12:54  	at org.jacoco.core.analysis.Analyzer.analyzeClass(Analyzer.java:132)
10:12:54  Caused: java.io.IOException: Error while analyzing /var/jenkins/jobs/rapids_premerge-g

Investigate solutions or perhaps run jacoco differently.

@tgravescs tgravescs added ? - Needs Triage Need team to review and classify build Related to CI / CD or cleanly building labels Sep 24, 2021
@revans2
Copy link
Collaborator

revans2 commented Sep 28, 2021

@sameerz One option to fix this is to just remove all of the JaCoCo code coverage. No one really looks at the numbers and enough has changed with the build, 3.2 and splitting the tests into separate builds, the numbers no longer really show that much of a full picture of what is happening. Should we spend more time to make this useful? Or do we just remove it all together?

@sameerz
Copy link
Collaborator

sameerz commented Sep 29, 2021

Short term we can disable JaCoCo. Mid term we should re-investigate how we measure code coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants