Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] approx_percentile returns array of zero percentiles instead of null in some cases #3706

Closed
andygrove opened this issue Sep 29, 2021 · 1 comment · Fixed by #3770
Closed
Assignees
Labels
bug Something isn't working P0 Must have for release

Comments

@andygrove
Copy link
Contributor

Describe the bug

I just saw this while debugging another issue. The rows here are CPU exact, CPU approx, GPU approx. GPU should have returned None as well.

Row(k='oy\x08Y£àK<', the_percentile=None)
Row(k='oy\x08Y£àK<', the_percentile=None)
Row(k='oy\x08Y£àK<', the_percentile=[0.0, 0.0, 0.0, 0.0, 0.0])

Steps/Code to reproduce bug
TBD I am working on improving the integration tests to catch this.

Expected behavior
CPU and GPU should match.

Environment details (please complete the following information)
N/A

Additional context
N/A

@andygrove andygrove added bug Something isn't working ? - Needs Triage Need team to review and classify labels Sep 29, 2021
@andygrove andygrove added this to the Sep 27 - Oct 1 milestone Sep 29, 2021
@andygrove andygrove self-assigned this Sep 29, 2021
@andygrove andygrove removed this from the Sep 27 - Oct 1 milestone Sep 29, 2021
@sameerz sameerz added P0 Must have for release and removed ? - Needs Triage Need team to review and classify labels Oct 5, 2021
@andygrove andygrove added this to the Oct 4 - Oct 15 milestone Oct 7, 2021
@andygrove
Copy link
Contributor Author

We have also seen illegal memory access errors related to this issue

@andygrove andygrove linked a pull request Oct 19, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0 Must have for release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants