Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] published rapids-4-spark dist artifact references aggregator #3929

Closed
gerashegalov opened this issue Oct 26, 2021 · 3 comments · Fixed by #3930
Closed

[BUG] published rapids-4-spark dist artifact references aggregator #3929

gerashegalov opened this issue Oct 26, 2021 · 3 comments · Fixed by #3930
Assignees
Labels
bug Something isn't working build Related to CI / CD or cleanly building

Comments

@gerashegalov
Copy link
Collaborator

Describe the bug

Originally reported by @NvTimLiu

Previously we relied on the shade plugin to get rid of transitive dependencies in dist/pom.xml. In 21.10 we pushed it into aggregator because this is the last stage with the conventional jar layout. The consequence is that we have the reduced dependency pom only at the aggregator level whereas we still retain a dangling reference to the aggregator pom itself in the dist jar.

Steps/Code to reproduce bug
./build/buildall -p=320

Expected behavior
No dependency pom should be published.

We could generate stage a reduced dependency pom just like the shad plugin "manually"

Environment details (please complete the following information)
dev/ci

Additional context
#3223

@gerashegalov gerashegalov added bug Something isn't working ? - Needs Triage Need team to review and classify build Related to CI / CD or cleanly building labels Oct 26, 2021
@jlowe
Copy link
Member

jlowe commented Oct 26, 2021

Is this a duplicate of #3927?

@gerashegalov
Copy link
Collaborator Author

Is this a duplicate of #3927?

Maybe. However, we could actually use #3927 for potentially adding the workaround -Dtransitive=true https://maven.apache.org/plugins/maven-dependency-plugin/get-mojo.html

and this one for the root cause fix

@NvTimLiu
Copy link
Collaborator

Close the issue per #3930 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants