Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support null characters in regular expressions in RLIKE #3962

Closed
andygrove opened this issue Oct 28, 2021 · 1 comment · Fixed by #4044
Closed

[FEA] Support null characters in regular expressions in RLIKE #3962

andygrove opened this issue Oct 28, 2021 · 1 comment · Fixed by #4044
Assignees
Labels
feature request New feature or request

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Given this input dataset:

  • ab
  • a\u0000b

The behavior or RLIKE differs between CPU and GPU when the pattern contains a null character:

Pattern Spark on CPU Spark on GPU
a\\0b Illegal octal escape sequence near index 3 Correct result
a\0b Correct result Incorrect result
a\u0000b Correct result Incorrect result
a\\x00b Correct result Correct result

Describe the solution you'd like
Ideally, we should have the same behavior as Spark but if this is not possible then we could consider falling back to CPU and maybe having a separate config to enable/disable supporting null characters in regex.

Describe alternatives you've considered
None

Additional context
This is closely related to #3876

@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels Oct 28, 2021
@andygrove andygrove added this to the Nov 1 - Nov 12 milestone Nov 2, 2021
@Salonijain27 Salonijain27 removed the ? - Needs Triage Need team to review and classify label Nov 2, 2021
@andygrove
Copy link
Contributor Author

This was implemented in #4044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants