Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ParseDateTimeSuite UT failed #4176

Closed
pxLi opened this issue Nov 22, 2021 · 7 comments · Fixed by #4352
Closed

[BUG] ParseDateTimeSuite UT failed #4176

pxLi opened this issue Nov 22, 2021 · 7 comments · Fixed by #4352
Assignees
Labels
bug Something isn't working P0 Must have for release

Comments

@pxLi
Copy link
Collaborator

pxLi commented Nov 22, 2021

Describe the bug
mvn -Dbuildver=302 clean package -DwildcardSuites=com.nvidia.spark.rapids.ParseDateTimeSuite
mvn -Dbuildver=312 clean package -DwildcardSuites=com.nvidia.spark.rapids.ParseDateTimeSuite

ParseDateTimeSuite:
- to_date dd/MM/yy (fall back)
- to_date yyyy-MM-dd *** FAILED ***
  Mismatch between CPU and GPU for the following rows:

  [#40] CPU: [1999-12-29
  ,null]
  [#40] GPU: [1999-12-29
  ,1999-12-29] (ParseDateTimeSuite.scala:302)
- to_date yyyy-MM-dd LEGACY
- to_date yyyy/MM/dd LEGACY
- to_date dd/MM/yyyy
- to_date dd/MM/yyyy LEGACY
- to_date parse date
- to_date parse timestamp
- to_timestamp yyyy-MM-dd *** FAILED ***
  Mismatch between CPU and GPU for the following rows:

  [#35] CPU: [1999-12-29
  ,null]
  [#35] GPU: [1999-12-29
  ,1999-12-29 00:00:00.0] (ParseDateTimeSuite.scala:302)
- to_timestamp dd/MM/yyyy
- to_date default pattern
- unix_timestamp parse date *** FAILED ***
  Mismatch between CPU and GPU for the following rows:

  [#35] CPU: [1999-12-29
  ,null]
  [#35] GPU: [1999-12-29
  ,946425600] (ParseDateTimeSuite.scala:302)
@pxLi pxLi added bug Something isn't working ? - Needs Triage Need team to review and classify labels Nov 22, 2021
@revans2
Copy link
Collaborator

revans2 commented Nov 22, 2021

This appears to be for 22.02.0-SNAPSHOT and is not failing on 21.12

@tgravescs tgravescs added the P0 Must have for release label Nov 23, 2021
@tgravescs tgravescs self-assigned this Nov 23, 2021
@tgravescs
Copy link
Collaborator

the failure here is caused when there is a newline in the string:

val ts = Seq("1999-12-29\n")

@tgravescs
Copy link
Collaborator

tgravescs commented Nov 23, 2021

I am not positive on this but this commit is dealing with newline and is about the time our test started to fail:

rapidsai/cudf@c1bfb26
rapidsai/cudf#9620

I might be wrong because its dealing with regex vs string to timestamp but that is the only change I saw in the code. I will verify

@tgravescs
Copy link
Collaborator

so I confirmed that reverting 6dc7b1d16f0eecdc2f932a6f9b94af630db534c5 - Fix regex non-multiline EOL/$ matching strings ending with a new-line (#9715)

make the behavior go back and the test passes

@tgravescs
Copy link
Collaborator

cudf issue: rapidsai/cudf#9764

@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Nov 23, 2021
@tgravescs
Copy link
Collaborator

PR up to temporarily disable the tests, they need to be re-enabled when cudf is fixed

@andygrove
Copy link
Contributor

We should be able to re-enable these tests now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0 Must have for release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants