Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]GpuSequence blows up when nulls exist in any of the inputs (start, stop, step) #4499

Closed
firestarman opened this issue Jan 11, 2022 · 1 comment · Fixed by #4520
Closed
Assignees
Labels
bug Something isn't working P0 Must have for release

Comments

@firestarman
Copy link
Collaborator

firestarman commented Jan 11, 2022

Describe the bug
GpuSequence blows up when nulls exist in any of the inputs (start, stop, step), e.g.

Caused by: ai.rapids.cudf.CudfException: cuDF failure at: ../src/lists/sequences.cu:148: steps input column must not have nulls.
  at ai.rapids.cudf.ColumnVector.sequences(Native Method)
  at ai.rapids.cudf.ColumnVector.sequence(ColumnVector.java:533)

but Spark just returns nulls.

+---+---+----------------------+
| _1| _2|sequence(_1, _2, NULL)|
+---+---+----------------------+
|  1|  2|                  null|
|  3|  4|                  null|
+---+---+----------------------+

Steps/Code to reproduce bug
Launch a Spark shell with GPU support, and run
Seq((1, 2), (3, 4)).toDF.repartition(1).selectExpr("*", "sequence(_1, _2, null)").show

Expected behavior
We should keep align with what Spark does for null cases.

@firestarman firestarman added bug Something isn't working ? - Needs Triage Need team to review and classify labels Jan 11, 2022
@firestarman
Copy link
Collaborator Author

firestarman commented Jan 11, 2022

Filed the FEA issue rapidsai/cudf#10012 to cudf for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0 Must have for release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants