Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Research associating MemoryCleaner to Spark's ShutdownHookManager #4676

Closed
abellina opened this issue Feb 1, 2022 · 2 comments
Closed
Labels
bug Something isn't working good first issue Good for newcomers test Only impacts tests

Comments

@abellina
Copy link
Collaborator

abellina commented Feb 1, 2022

This task could live in cuDF but I am putting it here since it is Spark related. We can add another issue in cuDF if we want to proceed.

This issue: #4669 brought to light a shutdown race between JVM's shutdown hooks and Spark's orderly ShutdownHookManager (also triggered by the JVM). Since the JVM doesn't guarantee the order of execution, the MemoryCleaner in cuDF could think there is a leak, which it checks when shutting down, when it really is a false positive since the SparkContext hasn't been stopped (so ExecutorPlugin is still alive, and so is the RapidsBufferCatalog).

Ideally we could add the MemoryCleaner leak check as the lowest priority (last) hook that Spark will trigger, to prevent false positives.

This is only visible when the ref count debug is turned on, so it is not an issue for production jobs, and hence it is low priority.

@abellina abellina added feature request New feature or request good first issue Good for newcomers ? - Needs Triage Need team to review and classify labels Feb 1, 2022
@sameerz sameerz added bug Something isn't working test Only impacts tests and removed feature request New feature or request ? - Needs Triage Need team to review and classify labels Feb 1, 2022
@res-life
Copy link
Collaborator

res-life commented Jul 8, 2022

@abellina We can close this issue via #5854, please double-check.

@abellina
Copy link
Collaborator Author

abellina commented Jul 8, 2022

Yes this is the same thing @res-life. Thanks!

@abellina abellina closed this as completed Jul 8, 2022
@pxLi pxLi changed the title [FEA] Research associating MemoryCleaner to Spark's ShutdownHookManager [BUG] Research associating MemoryCleaner to Spark's ShutdownHookManager Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers test Only impacts tests
Projects
None yet
Development

No branches or pull requests

3 participants