Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove input upcast in GpuExtractChunk32 #4777

Closed
jlowe opened this issue Feb 14, 2022 · 0 comments · Fixed by #4805
Closed

Remove input upcast in GpuExtractChunk32 #4777

jlowe opened this issue Feb 14, 2022 · 0 comments · Fixed by #4805
Assignees
@jlowe
Labels
feature request New feature or request performance A performance related task/issue

Comments

@jlowe
Copy link
Member

jlowe commented Feb 14, 2022

After rapidsai/cudf#10250 we should be able to remove the input upcast in GpuExtractChunk32.

As part of the change, we will need to create new unsigned DataType classes to handle UINT32 columns for the incoming data of the three least significant chunks and UINT64 columns for the resulting aggregations on those columns.
@jlowe jlowe added feature request New feature or request ? - Needs Triage Need team to review and classify performance A performance related task/issue labels Feb 14, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Feb 15, 2022
@jlowe jlowe mentioned this issue Feb 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlowe jlowe

Labels
feature request New feature or request performance A performance related task/issue
Projects
None yet
Milestone
No milestone
2 participants
@jlowe @sameerz