Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Optimize JSON reading of floating-point values #4837

Closed
andygrove opened this issue Feb 22, 2022 · 0 comments · Fixed by #5879
Closed

[FEA] Optimize JSON reading of floating-point values #4837

andygrove opened this issue Feb 22, 2022 · 0 comments · Fixed by #5879
Assignees
Labels
performance A performance related task/issue

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
PR #4825 fixes some edge cases with parsing JSON numeric types but introduces an additional complex regular expression and also calls into GpuCast.sanitizeStringToFloat which also executes a complex regular expression which is mostly redundant for this path.

Describe the solution you'd like
The JSON reader should implement optimized custom code for casting string to float instead of re-using the GpuCast logic.

Describe alternatives you've considered
None

Additional context
None

@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels Feb 22, 2022
@andygrove andygrove added this to the Feb 14 - Feb 25 milestone Feb 22, 2022
@andygrove andygrove self-assigned this Feb 22, 2022
@jlowe jlowe removed the ? - Needs Triage Need team to review and classify label Feb 22, 2022
@andygrove andygrove mentioned this issue Feb 23, 2022
62 tasks
@andygrove andygrove removed this from the Feb 28 - Mar 18 milestone Mar 11, 2022
@andygrove andygrove removed their assignment May 20, 2022
@andygrove andygrove self-assigned this Jun 13, 2022
@andygrove andygrove added this to the Jun 6 - Jun 17 milestone Jun 13, 2022
@sameerz sameerz removed this from the Jun 6 - Jun 17 milestone Jun 18, 2022
@andygrove andygrove added this to the Jun 20 - Jul 8 milestone Jun 21, 2022
@sameerz sameerz added performance A performance related task/issue and removed feature request New feature or request labels Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance A performance related task/issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants