Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Update integration tests to compare result schemas between GPU and CPU #5072

Open
andygrove opened this issue Mar 28, 2022 · 0 comments
Labels
test Only impacts tests

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Many of our integration tests run the same query on GPU then CPU and compare the results. It would be nice to also compare the result schema so that we can be sure that we return the same column names, types, and nullability flags.

Describe the solution you'd like
Update the assert_gpu_and_cpu_are_equal_* methods to compare schema as well as results. We should add an option to disable these checks since there may be edge cases that we won't support.

Describe alternatives you've considered
None

Additional context
N/A

@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify test Only impacts tests labels Mar 28, 2022
@sameerz sameerz removed feature request New feature or request ? - Needs Triage Need team to review and classify labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

No branches or pull requests

2 participants