Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Some arithmetic tests are failing on Spark 3.4.0 #5480

Closed
firestarman opened this issue May 13, 2022 · 2 comments · Fixed by #5675
Closed

[BUG] Some arithmetic tests are failing on Spark 3.4.0 #5480

firestarman opened this issue May 13, 2022 · 2 comments · Fixed by #5675
Assignees
Labels
bug Something isn't working

Comments

@firestarman
Copy link
Collaborator

firestarman commented May 13, 2022

List all the failing tests here now, we can file separate issues when working on them.

FAILED ../../src/main/python/arithmetic_ops_test.py::test_div_by_zero_ansi[1/0]
FAILED ../../src/main/python/arithmetic_ops_test.py::test_div_by_zero_ansi[a/0]
FAILED ../../src/main/python/arithmetic_ops_test.py::test_div_by_zero_ansi[a/b]
FAILED ../../src/main/python/arithmetic_ops_test.py::test_div_overflow_exception_when_ansi[true-CAST(-9223372036854775808L as LONG) DIV -1]
FAILED ../../src/main/python/arithmetic_ops_test.py::test_div_overflow_exception_when_ansi[true-a DIV CAST(-1 AS INT)]
FAILED ../../src/main/python/arithmetic_ops_test.py::test_div_overflow_exception_when_ansi[true-a DIV b]

Steps/Code to reproduce bug

  1. Build the plugin jar by mvn clean package -DskipTests -Dbuildver=340.
  2. Run the test.
cd integration_tests
./run_pyspark_from_build.sh -k test_xxxxxx

Expected behavior
The tests should pass

@firestarman firestarman added bug Something isn't working ? - Needs Triage Need team to review and classify labels May 13, 2022
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label May 17, 2022
@firestarman
Copy link
Collaborator Author

firestarman commented May 27, 2022

Tests test_cast_double_to_timestamp are passing now. They should be fixed by #5514.
Removed them from the list.

@firestarman
Copy link
Collaborator Author

firestarman commented May 27, 2022

The following tests are also passing now.

test_parquet_read_daytime_interval_cpu_file
test_parquet_read_daytime_interval_gpu_file
test_parquet_push_down_on_interval_type

Removed them from the list.

@firestarman firestarman changed the title [BUG]Some integration tests are failing on Spark 3.4.0 [BUG]Some arithmetic tests are failing on Spark 3.4.0 May 27, 2022
@sameerz sameerz changed the title [BUG]Some arithmetic tests are failing on Spark 3.4.0 [BUG] Some arithmetic tests are failing on Spark 3.4.0 Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants