Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Re-instate "transpile complex regex 2" test in some form #5656

Closed
andygrove opened this issue May 26, 2022 · 0 comments · Fixed by #6027
Closed

[FEA] Re-instate "transpile complex regex 2" test in some form #5656

andygrove opened this issue May 26, 2022 · 0 comments · Fixed by #6027
Labels
test Only impacts tests

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In PR #5610 the following test was ignored. This is a follow on issue to decide what to do with this test. Maybe it needs modifying and kept as a general test for the transpiler.

  // this was a test for transpiling but we did not ever try to run the
  // resulting regex to see if it produced valid results
  ignore("transpile complex regex 2") {
    val TIMESTAMP_TRUNCATE_REGEX = "^([0-9]{4}-[0-9]{2}-[0-9]{2} " +
      "[0-9]{2}:[0-9]{2}:[0-9]{2})" +
      "(.[1-9]*(?:0)?[1-9]+)?(.0*[1-9]+)?(?:.0*)?\\z"

    // input and output should be identical except for `.` being replaced 
    // with `[^\n\r\u0085\u2028\u2029]` and `\z` being replaced with `$`
    doTranspileTest(TIMESTAMP_TRUNCATE_REGEX,
      TIMESTAMP_TRUNCATE_REGEX
        .replaceAll("\\.", "[^\n\r\u0085\u2028\u2029]")
        .replaceAll("\\\\z", "\\$"))
  }

Describe the solution you'd like
TBD

Describe alternatives you've considered
None

Additional context
None

@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels May 26, 2022
@andygrove andygrove self-assigned this May 26, 2022
@sameerz sameerz added test Only impacts tests and removed feature request New feature or request ? - Needs Triage Need team to review and classify labels May 31, 2022
@andygrove andygrove removed their assignment Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants