Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support Percentile #6266

Closed
viadea opened this issue Aug 9, 2022 · 3 comments · Fixed by #9296
Closed

[FEA] Support Percentile #6266

viadea opened this issue Aug 9, 2022 · 3 comments · Fixed by #9296
Assignees
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request

Comments

@viadea
Copy link
Collaborator

viadea commented Aug 9, 2022

I wish we can support function Percentile.

Eg:

select percentile(ss_wholesale_cost,0.1) from tpcds.store_sales limit 10;

    ! <Percentile> percentile(ss_wholesale_cost#82, 0.1, 1, 0, 0) cannot run on GPU because GPU does not currently support the operator class org.apache.spark.sql.catalyst.expressions.aggregate.Percentile
@viadea viadea added feature request New feature or request ? - Needs Triage Need team to review and classify labels Aug 9, 2022
@sameerz sameerz added cudf_dependency An issue or PR with this label depends on a new feature in cudf and removed ? - Needs Triage Need team to review and classify labels Aug 9, 2022
@revans2
Copy link
Collaborator

revans2 commented Aug 15, 2023

We need some more information here. Is this just for a reduction. Is this needed for group by as well? What about a window operation? What are the data types we need to support. (Everything is cast to a double so it might be okay, but casting decimal to doubles can be difficult in some cases)

@revans2
Copy link
Collaborator

revans2 commented Aug 15, 2023

I filed rapidsai/cudf#13885 to support group by and reduction aggregations for this in CUDF. It will not cover window. We would still need to use this for plugin side changes and testing.

@nvliyuan
Copy link
Collaborator

I am checking more detailed requirements from customers

@ttnghia ttnghia self-assigned this Sep 18, 2023
@ttnghia ttnghia linked a pull request Oct 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants