Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Remove the hasNans config from the test code. #6487

Closed
HaoYang670 opened this issue Sep 2, 2022 · 0 comments · Fixed by #6512
Closed

[FEA] Remove the hasNans config from the test code. #6487

HaoYang670 opened this issue Sep 2, 2022 · 0 comments · Fixed by #6512
Assignees
@HaoYang670
Labels
test Only impacts tests

Comments

@HaoYang670
Copy link
Collaborator

HaoYang670 commented Sep 2, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
After finishing #5320, we should remove all hasNans config in the tests.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context, code examples, or references to existing implementations about the feature request here.
@HaoYang670 HaoYang670 added feature request New feature or request ? - Needs Triage Need team to review and classify test Only impacts tests labels Sep 2, 2022
@HaoYang670 HaoYang670 self-assigned this Sep 2, 2022
@HaoYang670 HaoYang670 mentioned this issue Sep 5, 2022
Closed
@sameerz sameerz removed feature request New feature or request ? - Needs Triage Need team to review and classify labels Sep 7, 2022
@HaoYang670 HaoYang670 mentioned this issue Sep 14, 2022
Merged
@HaoYang670 HaoYang670 changed the title [FEA] Clean the no_nan data_gen and config in the test code. [FEA] Remove the hasNans config from the test code. Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HaoYang670 HaoYang670

Labels
test Only impacts tests
Projects
None yet
Milestone
No milestone
2 participants
@sameerz @HaoYang670