Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support partial fallback to the CPU on Databricks for percentile #9494

Open
ttnghia opened this issue Oct 19, 2023 · 2 comments
Open
Labels
feature request New feature or request

Comments

@ttnghia
Copy link
Collaborator

ttnghia commented Oct 19, 2023

Somehow the plugin cannot replace Percentile class on Databricks when the replace mode is set to final|complete. As such, we cannot support partial fallback to the CPU.

The corresponding test (in #9296) needs to be xfail while the root cause needs to be investigated and tracked by this issue.

@ttnghia ttnghia added feature request New feature or request ? - Needs Triage Need team to review and classify labels Oct 19, 2023
@revans2
Copy link
Collaborator

revans2 commented Oct 20, 2023

I did some quick tests, and the plugin is complaining that

 cannot run on GPU because mixing CPU and GPU aggregations is not supported

for the first SortAggregateExec, but all of the children show that they are on the GPU. I'll try to dig a little deeper.

@revans2
Copy link
Collaborator

revans2 commented Oct 20, 2023

Okay I traced it down. We put in some code for databricks to prevent partial replacement in some cases and it is hitting here

#4963

is the issue to fix this. So we can decide if we are hitting this in error or not.

@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants