Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Review JsonToStruct and JsonScan and consolidate some testing and implementation #9750

Closed
andygrove opened this issue Nov 16, 2023 · 2 comments
Labels
feature request New feature or request

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
PR #9666 adds support for parsing dates from JSON specifically for GpuJsonToStructs and there are differences in how we handle parsing dates compared to GpuJsonScan.

Describe the solution you'd like
There are opportunities to make the code more consistent between the two approaches of parsing JSON and ensure that tests are consistent and have more coverage.

Describe alternatives you've considered

Additional context

@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels Nov 16, 2023
@andygrove andygrove self-assigned this Nov 16, 2023
@andygrove
Copy link
Contributor Author

This is related to #4940 as well

@revans2
Copy link
Collaborator

revans2 commented Mar 14, 2024

I think this was mostly done by #10542

But the testing is being done by #10491 and #10492

There are also a lot of follow on fixes that need to be done.

@revans2 revans2 closed this as completed Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants