-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release notes to include qualification and profiling tools #2848
Update release notes to include qualification and profiling tools #2848
Conversation
Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
@@ -73,6 +73,10 @@ New functionality for this release includes: | |||
* Range windows supporting non-timestamp order by expressions | |||
* Enabling large joins that can spill out of memory | |||
* Support for the `concat_ws` operator | |||
* Spark Qualification and Profiling Tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want a pointer to the tools README or more information here? Wondering how users reading this and want to know more are supposed to find more info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit disappointed that this comment was completely ignored before the PR was merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit disappointed that this comment was completely ignored before the PR was merged.
Sorry not sure how I missed this comment before merging, I might have thought I was responding to the comment in the related 21.08 PR - #2849 (comment) . Asking @viadea to create documentation for the profiling tool that will reside in the gh-pages docs in 21.08.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy to add a link to in gh-pages to the profiling tools readme at this point if you still think it is worthwhile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to have the gh-pages version of the release notes and the checked-in version differ unless it's critical to fix something and we can't keep them in sync. If we want to do something there, we should fix it in branch-21.08 and possibly pull that change into gh-pages early. If there's no good doc to point to until 21.08 then I don't see a need to rush and fix this for 21.06.
Signed-off-by: Sameer Raheja <sraheja@nvidia.com>
Mention qualification and profiling tools in release notes. Once this is merged I will add this commit to branch-21.08.