Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on the implementation of rotation augmentation #51

Open
TongZhangTHU opened this issue Aug 22, 2024 · 0 comments
Open

Question on the implementation of rotation augmentation #51

TongZhangTHU opened this issue Aug 22, 2024 · 0 comments

Comments

@TongZhangTHU
Copy link

TongZhangTHU commented Aug 22, 2024

Thank you for your great work.

I noticed that in the apply_se3_aug_con function for rotation augmentation, there are two options, ver=1 and ver=2. However, I observed that at line 364 ( ver=1) and line 368 ( ver=2) in augmentation.py, the rotation is handled differently. Specifically, in ver=1, the rotation matrix is applied via right multiplication, whereas in ver=2, it's applied via the transpose of the rotation matrix using left multiplication. Generally, these two approaches yield different results. I noticed that PerAct uses the former, while RVT uses the latter. Could you please explain why you are using the latter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant