Fixes a bug when presenting NYTPhotoViewer from a subview of UIStackView #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to `alpha`. Using `hidden` to control the visibility of `UIView`’s contained in `UIStackView` has the side effect of affecting the layout of items within the stack view. Setting the view’s `alpha` does not have this effect.
|
@cdzombak Any thoughts on this changeset? |
/me grumbles |
cdzombak
added a commit
that referenced
this pull request
Jan 4, 2016
…d-of-hidden Fixes a bug when presenting NYTPhotoViewer from a subview of UIStackView
|
Was taking a look at this when @cdzombak merged it. Looks good. Tests fine. 👍 |
|
oh, sorry, @soundsokay :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it Does
Switches the animated and interactive transition from using
hiddentoalpha.Using
hiddento control the visibility ofUIView’s contained inUIStackViewhas the side effect of affecting the layout of items within the stack view. Setting the view’salphadoes not have thiseffect.
How to Test
UIStackViewincluding other views.cc @bcapps who co-authored this patch.