Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option:selected fix for zepto #58

Merged
merged 1 commit into from
Jan 24, 2013
Merged

option:selected fix for zepto #58

merged 1 commit into from
Jan 24, 2013

Conversation

waymondo
Copy link
Contributor

zepto does not support the ":selected" pseudo selector and thus breaks building a select form field using selectOptions. i've updated this option selecting function to work without the use of the pseudo selector.

delambo added a commit that referenced this pull request Jan 24, 2013
delambo added a commit that referenced this pull request Jan 24, 2013
@delambo delambo merged commit d3e0f97 into nytimes:master Jan 24, 2013
@delambo
Copy link
Member

delambo commented Jan 24, 2013

Ack, thanks for bringing this to my attention. I was way behind on zepto support and had to update a lot of tests and fix some code. I also discovered that zepto's .data really sucks so /selectOptions don't work without including the data module.

@waymondo
Copy link
Contributor Author

no prob, glad to lend a nominal hand on this super handy extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants