Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing js.map in Frontend SDK #385

Closed
bastienbeurier opened this issue Mar 21, 2023 · 4 comments · Fixed by #542
Closed

Missing js.map in Frontend SDK #385

bastienbeurier opened this issue Mar 21, 2023 · 4 comments · Fixed by #542
Labels
wontfix This will not be worked on

Comments

@bastienbeurier
Copy link
Member

Using the frontend SDK in a React app shows the following error:
Screenshot 2023-03-21 at 06 36 30
@bastienbeurier bastienbeurier added bug Something isn't working good first issue labels Mar 21, 2023
@Chakravarthy7102 Chakravarthy7102 mentioned this issue Apr 16, 2023
Merged
@bastienbeurier
Copy link
Member Author

Additional info: #542 (comment)

@khaliqgant khaliqgant mentioned this issue May 2, 2023
Merged
@bastienbeurier bastienbeurier reopened this May 2, 2023
@bastienbeurier
Copy link
Member Author

Had to reopen because of a bug the fix was creating -> #614

The outside fix is tracked here facebook/create-react-app#11752

@bastienbeurier bastienbeurier moved this from Done to Later in Nango Roadmap Jul 6, 2023
@gorets
Copy link
Contributor

gorets commented Nov 1, 2023 •
edited
Loading

Your dist/index.js has relation # sourceMappingURL=index.js.map but file index.js.map doesn't included in the npm package.

I think it would be correct to add this file to the package, but whether it will be used or not in the final application bundle should be decided by the author of the application, and not the author of a specific module.

P.S. see bootstrap as example

image

@bastienbeurier
Copy link
Member Author

Moved to internal issue tracker

@github-project-automation github-project-automation bot moved this from Later to Done in Nango Roadmap Dec 4, 2023
@bastienbeurier bastienbeurier added wontfix This will not be worked on and removed bug Something isn't working labels Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: added new scripts to gen source-maps on install
2 participants
@gorets @bastienbeurier