Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow not failing if there are test failures #84

Closed
bhojjoshi opened this issue Jan 12, 2021 · 2 comments · Fixed by #138
Closed

Workflow not failing if there are test failures #84

bhojjoshi opened this issue Jan 12, 2021 · 2 comments · Fixed by #138
Assignees
Labels
enhancement New feature or request

Comments

@bhojjoshi
Copy link

trx-parser is not configurable for whether to break the workflow or proceed further in case of test failures, rather all the following steps/jobs get executed regardless of test status.

It would give more control to a developer if trx-parser can be configured based on some input parameters such as BREAK_ON_TEST_FAILURE with boolean values or similar.

@NasAmin NasAmin added the enhancement New feature or request label Jan 12, 2021
@NasAmin NasAmin self-assigned this Jan 12, 2021
@NasAmin
Copy link
Owner

NasAmin commented Jan 12, 2021

Thanks @bhojjoshi
For the time being there is a workaround as follows:
This actions produces an output call test-outcome. If there is at least one test failure, it will set this output to Failed.
You could then access this output of the action has run as a separate step in your pipeline.

I'll enhance this workflow with a new flag. The default will be the current behaviour but if the user sets the new flag then it will fail the task with exit code 1.

@bhojjoshi
Copy link
Author

Yes, the workaround is working for me for now. Thanks!

@NasAmin NasAmin mentioned this issue Apr 14, 2021
1 task
@NasAmin NasAmin linked a pull request Apr 14, 2021 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants