Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid double verification of DataColumnSidecars in simple Sampler #123

Open
zilm13 opened this issue Sep 4, 2024 · 0 comments
Open

Avoid double verification of DataColumnSidecars in simple Sampler #123

zilm13 opened this issue Sep 4, 2024 · 0 comments

Comments

@zilm13
Copy link
Collaborator

zilm13 commented Sep 4, 2024

Data availability check in ForkChoice should ensure:

  • Sidecar was seen and we were able to download it
  • kzg proof verification is passed for it

For any custody sidecar in DB:

  • we were able to download it
  • kzg verification was run (at least for incoming sidecars, clarify for block where we were a proposer)

So for simple Sampler in Forkchoice we don't need to get it from DB and run kzg verification. We should only check that DataColumnSidecarIdentifier exists in DB in ForkChoice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant